Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Order Amount calculation integration #4427

Merged
merged 4 commits into from
Jun 2, 2020
Merged

feat: Order Amount calculation integration #4427

merged 4 commits into from
Jun 2, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented May 31, 2020 •
edited
Loading

  • Debug why donation ticket validation is not working

Fixes #3710

@vercel
Copy link

vercel bot commented May 31, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/uiba16iye
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-order-amount.eventyay.now.sh

@lgtm-com
Copy link

lgtm-com bot commented May 31, 2020

This pull request introduces 1 alert when merging d5f0eab into 7e87e5b - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@iamareebjamal iamareebjamal changed the title wip: Order Amount calculation integration feat: Order Amount calculation integration Jun 1, 2020
@auto-label auto-label bot added the feature label Jun 1, 2020
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #4427 into development will not change coverage.
The diff coverage is 23.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4427   +/-   ##
============================================
  Coverage        22.58%   22.58%           
============================================
  Files              469      469           
  Lines             4963     4963           
  Branches             6        6           
============================================
  Hits              1121     1121           
  Misses            3841     3841           
  Partials             1        1
Impacted Files Coverage Δ
app/utils/dictionary/payment.ts 100.00% <ø> (ø)
app/components/public/ticket-list.js 17.69% <20.68%> (ø)
app/helpers/currency-symbol.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b21764...d452890. Read the comment docs.

@iamareebjamal iamareebjamal merged commit eeb15a9 into fossasia:development Jun 2, 2020
@iamareebjamal iamareebjamal deleted the order-amount branch June 2, 2020 01:52
@iamareebjamal iamareebjamal mentioned this pull request Jul 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tax not added or calculated
1 participant
@iamareebjamal